refactoring: imagery library resolve cppcheck warnings #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you used clang-format, we currently use a specific configuration file together with version 15 of clang-format. Version changes of clang-format have varying output, so we stick to one for a while to limit churn. This explains the clang-format CI failure you can see. |
Sharansrj567
force-pushed
the
imagery-group-refactor
branch
from
e6f9ab4
to
8270ae4
Compare
marisn
requested changes
Jan 13, 2024
Sharansrj567
force-pushed
the
imagery-group-refactor
branch
from
8270ae4
to
b02fda8
Compare
marisn
approved these changes
Jan 14, 2024
neteler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses warnings identified by Cppcheck in the lib/imagery/group.c file:
[duplicateExpression]: Refactored redundant conditions in the color assignment logic for improved code clarity.
[invalidscanf]: Added limits to fscanf to prevent potential crashes with large string inputs.
[variableScope]: Reduced variable scope to address scope warnings.
These modifications aim to enhance code clarity, ensure safer input processing, and resolve scope-related warnings in the imagery library.
Changes Made:
Refactored redundant conditions in color assignment logic.
Added limits to fscanf for safer input processing.
Reduced variable scope to address scope warnings.
Testing:
Manual testing performed to ensure the behavior of group.c functions remains unchanged.
Style check conducted using clang-format to maintain standard formatting.